Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan for upgrading to lottie-ios 3.x #481

Closed
tonyxiao opened this issue May 13, 2019 · 5 comments
Closed

Plan for upgrading to lottie-ios 3.x #481

tonyxiao opened this issue May 13, 2019 · 5 comments

Comments

@tonyxiao
Copy link

According to https://github.com/airbnb/lottie-ios/blob/master/Documentation/MIGRATING.md, Lottie 2.x is now in maintenance mode. Is there a plan to upgrade to lottie 3.x? Are there anything preventing that from happening?
@emilioicai
Copy link
Member

I'm working on it but I'm making very slow progress. I would appreciate some help moving forward :)

@lorenc-tomasz
Copy link
Contributor

@emilioicai Maybe you can share your WiP?

@emilioicai emilioicai mentioned this issue May 17, 2019
Closed
@prateekkohli1989
Copy link

@emilioicai I am able to upgrade to 3.x. Since Lottie-iOS doesn't allow to load animation from JSON how would you suggest to load the lottie json in the react native app? using filePath or bundle ?

@binjospookie
Copy link

@prateekkohli1989 which way can provide better performance? filePath sounds good.

@prateekkohli1989
Copy link

@emilioicai I had raised the PR for the lottie-ios upgrade. Please review #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tonyxiao @emilioicai @lorenc-tomasz @prateekkohli1989 @binjospookie