Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflows for generating windows and linux binaries #35

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

amir16yp
Copy link
Contributor

Made a workflow for generating windows and linux binaries with pyinstaller. to use them simply create a release and artifacts would be automatically be added. example here https://github.com/amir16yp/arnis/releases/tag/1.0

i would say either delay merging this until @daniil2327 GUI is done, or merge it now and make a quick release of the current state of the program. your choice.

Btw i tried various ways to optimize the prorgam, but somehow, according to the benchmarks i made with the same 3 squared km, it somehow got slower, so i scrapped those additions for now. the only optimization that kind of worked was a minor one for floodfill, but i will make a separate PR for that

@louis-e
Copy link
Owner

louis-e commented Aug 15, 2024

You're awesome, thanks a lot!
I'm spending hours on a huge refactoring and optimization right now, looking forward to pushing it in the next few days. This massively improves the performance and efficiency. I will look into your changes soon and merge them! :)

@daniil2327
Copy link
Contributor

You can merge it because i have problems with gui

@louis-e
Copy link
Owner

louis-e commented Aug 15, 2024

Alright! Since I spent the last 14 hours with a complete refactoring, I'll take a nap now lol. So I'll check tomorrow if your PR still works with the recent changes and merge it. Huge thanks to you guys for contributing!

@amir16yp
Copy link
Contributor Author

@louis-e
Copy link
Owner

louis-e commented Aug 16, 2024

Just tested it, looks good to me.
I'll merge it for now, the only problem is that Microsoft classifies it as a virus, seems to be a common problem with pyinstaller builds (pyinstaller/pyinstaller#5854 (comment) / https://medium.com/@markhank/how-to-stop-your-python-programs-being-seen-as-malware-bfd7eb407a7). Maybe we can continue the GUI idea, this should make it more accessible for people without console or python knowledge. Btw I'm also thinking about rewriting this entire project in C++ if there's a library for editing the Minecraft region files. That should make it even more efficient and faster. Also sounds like a bit of fun :)

@louis-e louis-e merged commit 1e88970 into louis-e:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants