Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sync): convert long tweets to threads #111

Merged
merged 8 commits into from
Nov 1, 2023
Merged

feat(sync): convert long tweets to threads #111

merged 8 commits into from
Nov 1, 2023

Conversation

louisgrasset
Copy link
Owner

@louisgrasset louisgrasset commented Nov 1, 2023 •
edited
Loading

This PR adds the following changes:

  • a new splitTweetText method
  • the related tests
  • the implementation for mastodon & bluesky

Closes #28.

@louisgrasset louisgrasset self-assigned this Nov 1, 2023
@louisgrasset louisgrasset force-pushed the feature/convert-long-tweets-to-threads branch from 7b3e5af to cd82989 Compare November 1, 2023 11:05
@louisgrasset louisgrasset force-pushed the feature/convert-long-tweets-to-threads branch from ff287f6 to 4ad5079 Compare November 1, 2023 12:25
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

44.3% 44.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@louisgrasset louisgrasset merged commit 0865b11 into main Nov 1, 2023
8 of 9 checks passed
@louisgrasset louisgrasset deleted the feature/convert-long-tweets-to-threads branch November 1, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralmn ralmn Awaiting requested review from ralmn

@ThePrincelle ThePrincelle Awaiting requested review from ThePrincelle

Assignees

@louisgrasset louisgrasset

Labels
bluesky enhancement New feature or request mastodon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(bluesky): tweets longer than 300 chars fail to sync
1 participant
@louisgrasset