Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale detection ignores English language since v1.23.12 #4690

Closed
1 task done
CirnoT opened this issue Apr 18, 2024 · 0 comments Β· Fixed by #4692
Closed
1 task done

Locale detection ignores English language since v1.23.12 #4690

CirnoT opened this issue Apr 18, 2024 · 0 comments Β· Fixed by #4692
Labels
area:core issues describing changes to the core of uptime kuma bug Something isn't working

Comments

@CirnoT
Copy link

CirnoT commented Apr 18, 2024

πŸ“‘ I have found these related issues/pull requests

#4244 (see review for exact cause)

πŸ›‘οΈ Security Policy

Description

English language is now silently skipped, even if browser indicates that it is of higher priority. Instead, the next highest priority language is used.

πŸ‘Ÿ Reproduction steps

navigator.languages => ['en-US', 'en', 'pl', 'ja']
Accept-Language: en-US,en;q=0.9,pl;q=0.8,ja;q=0.7

chrome_2024-04-19_00-25-01

πŸ‘€ Expected behavior

Interface and status page is displayed in English

πŸ˜“ Actual Behavior

Interface and status page is displayed in Polish

🐻 Uptime-Kuma Version

1.23.12

πŸ’» Operating System and Arch

Docker

🌐 Browser

Chromium124.0.6367.61

πŸ–₯️ Deployment Environment

  • Runtime: Docker version 25.0.4, build 1a576c5
  • Database: sqlite/embedded
  • Filesystem used to store the database on: ext4 via docker volume

πŸ“ Relevant log output

No response

@CirnoT CirnoT added the bug Something isn't working label Apr 18, 2024
@CirnoT CirnoT changed the title Locale ignores 'English' since v1.23.12 Locale detection ignores English language since v1.23.12 Apr 18, 2024
@CommanderStorm CommanderStorm linked a pull request Apr 19, 2024 that will close this issue
7 tasks
@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants