-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Localisation-matching algorithm missing some edgecase #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
CommanderStorm
changed the title
Localisation
fix: Localisation of Apr 19, 2024
en
-detection if there are other languages with lower priority
1 task
CommanderStorm
changed the title
fix: Localisation of
fix: Localisation-matching algorithm missing some edgecase
Apr 20, 2024
en
-detection if there are other languages with lower priority
1 task
louislam
reviewed
Apr 20, 2024
CommanderStorm
commented
Apr 20, 2024
CommanderStorm
commented
Apr 20, 2024
CommanderStorm
added
the
area:core
issues describing changes to the core of uptime kuma
label
Apr 21, 2024
Saibamen
reviewed
Apr 21, 2024
expect(currentLocale()).equal("en"); | ||
|
||
setLanguage('zz-ZZ'); | ||
setLanguages(['zz-ZZ']); | ||
expect(currentLocale()).equal("en"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same test case as in line 35
1 task
2 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Resolves #4691
Resolves #4690
Resolves #4697
There were these minor bugs in the new language selection mechanism introduced in
1.23.12
:en-US
this would been
) for the first entry of the languagesen
if other (less prefered) alternatives exist in the users preferences, as this is only in the messages and not in thelanguageList
.Our testcases missed this edgecase
thanks @CirnoT for the bug report
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)