Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement Max.Redirects & Accepted Status Codes #173

Merged
merged 10 commits into from
Aug 8, 2021

Conversation

chakflying
Copy link
Collaborator

This PR implements options in each monitor for:

  • The maximum number of redirects to follow,
  • The ranges of status codes to accept.

image

image

I'm a bit torn with the variable naming, since I want to follow the existing naming conventions, but true camel case should be maxRedirects.

multiselect support for Vue 3 has not hit stable yet, but functionality looks fine to me.

Also, sorry for bundling a bit of styling change, but I got really triggered by the lack of spacing 😂

@louislam louislam linked an issue Aug 5, 2021 that may be closed by this pull request
32 tasks
@louislam louislam removed a link to an issue Aug 5, 2021
32 tasks
@louislam louislam mentioned this pull request Aug 5, 2021
32 tasks
@louislam
Copy link
Owner

louislam commented Aug 5, 2021

Appreciate with the work!

The only problem is I think in this way, it cannot cover @Hyurt's use case. #11 (comment)

@chakflying
Copy link
Collaborator Author

Currently the user can select a mix of preset ranges and individual codes, so "200-299", "401", "402", "403" would work.

I guess the alternative would be to give user a text box and let them enter arbitrary ranges, but I'm not sure if having to handle parsing or client-side validation is worth the effort.

@louislam
Copy link
Owner

louislam commented Aug 5, 2021

Currently the user can select a mix of preset ranges and individual codes, so "200-299", "401", "402", "403" would work.

I guess the alternative would be to give user a text box and let them enter arbitrary ranges, but I'm not sure if having to handle parsing or client-side validation is worth the effort.

Nice, I do not checkout yet, I thought it accepts range only.🤣

@louislam louislam added this to the 1.1.0 milestone Aug 5, 2021
src/pages/EditMonitor.vue Outdated Show resolved Hide resolved
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
@louislam
Copy link
Owner

louislam commented Aug 6, 2021

Updated the color to match the theme.

Btw, I updated sqlite3, you may need to run "npm install" again.

@louislam louislam linked an issue Aug 7, 2021 that may be closed by this pull request
@louislam louislam merged commit 4439111 into louislam:master Aug 8, 2021
@chakflying chakflying deleted the redirects&status branch August 10, 2021 02:27
@louislam louislam mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants