-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implement Max.Redirects & Accepted Status Codes #173
Conversation
Appreciate with the work! The only problem is I think in this way, it cannot cover @Hyurt's use case. #11 (comment) |
Currently the user can select a mix of preset ranges and individual codes, so I guess the alternative would be to give user a text box and let them enter arbitrary ranges, but I'm not sure if having to handle parsing or client-side validation is worth the effort. |
Nice, I do not checkout yet, I thought it accepts range only.🤣 |
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Updated the color to match the theme. Btw, I updated sqlite3, you may need to run "npm install" again. |
This PR implements options in each monitor for:
I'm a bit torn with the variable naming, since I want to follow the existing naming conventions, but true camel case should be
maxRedirects
.multiselect
support for Vue 3 has not hit stable yet, but functionality looks fine to me.Also, sorry for bundling a bit of styling change, but I got really triggered by the lack of spacing 😂