-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improved comprehensive monitor list filtering #3312
Feat: Improved comprehensive monitor list filtering #3312
Conversation
Nice work. I prefer your solution rather than #1971. |
The "Add Monitor" button lines up with the edge of the monitor list, while the Filters lines up with the status pills of the monitors. The space left of the search box is reserved for #1886. |
Merging this should also close the PRs: |
Added a missing translate key and split |
Thanks for finding them, they will be closed. |
Just updated to 1.23 and trying the new filters. I love them, but... I have a monitor that is down, and this is under a nested group ("the lounge" under "Everything->Media") If I have the view unfiltered, the default, then everything shows as expected. If I filter for "down" monitors, then it seems to list everything multiple times. In this case, under "Everything", under "Everything / Media" and under "Everything / Media / thelounge". Also, when filtered, instead of showing the monitor name on its own, it shows all the groups above it - e.g. instead of "the lounge" it says "Everything / Media / thelounge" which makes it very difficult to read. |
Just tested this out and its nice but the feature should be on Status pages since thats whats showing on another screen we have running. |
Agreed - would love the Status screens to only show problems and not everything... |
@ajnadox @derekoharrow Some maintainers use 👍🏻 on issues to prioritise work, as always: Pull Requests welcome. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #1134.
Fixes #1585.
Design inspired by the GitHub mobile app. The left most button shows the number of active filters, and clears all active filters. Each category of filter is a multi-select, which when only one is selected, the filter state will be shown in the button, otherwise the generic "Status", "Active" is shown. Works independent of the search text.
This PR is a partial duplicate of #1971, but does not handle the filtering of the events list.
Also fixes bugs:
0
instead offalse
when it has no parentType of change
Checklist
(including JSDoc for methods)
Screenshots (if any)