-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Redirect /list
to /dashboard
for non-mobile users
#4492
base: master
Are you sure you want to change the base?
Conversation
/link
to /dashboard
for non-mobile users
/link
to /dashboard
for non-mobile users/list
to /dashboard
for non-mobile users
@CommanderStorm Reverted changes to the mobile mixin and corrected the redirect. Haven't ever used Vue - thanks for the help! |
Forgot to previously push the changes in the commit 8389f7c. Ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above when I was taking about
I think it would run during the init options api, but not when the browser changes its width => f.ex. gets larger
=> moving this logic toonResize()
seems like a better choice
I was thinking about this case:
=> is there a reason to keep this in the List.vue
and not move it to onResize
?
@CommanderStorm Do you mean we should check inside onResize whether we are in |
That would be my idea. |
The reverse does not need to happen. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #359
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
None