Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation unpin incident -> delete incident #4565

Merged
merged 1 commit into from
May 23, 2024
Merged

Translation unpin incident -> delete incident #4565

merged 1 commit into from
May 23, 2024

Conversation

LeoThies
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

I only changed "unpin" to "delete"

User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Mar 11, 2024
@CommanderStorm
Copy link
Collaborator

Yes agree that is a better string.

Since this touches translations, this will be merged after #4394 is merged in preparation for the next release

@chakflying chakflying added area:status-page Everything related to the status page area:ui/ux Interface and User Experience issues and removed house keeping labels Mar 29, 2024
@CommanderStorm CommanderStorm changed the title edit unpin to delete Translation unpin incident -> delete incident Apr 8, 2024
@CommanderStorm CommanderStorm added the pr:needs other pr merged pending other PR to be merged first label May 19, 2024
@CommanderStorm
Copy link
Collaborator

Merging as we had to merge #4394 due to #4788

@CommanderStorm CommanderStorm merged commit 07a0718 into louislam:master May 23, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:status-page Everything related to the status page area:ui/ux Interface and User Experience issues pr:needs other pr merged pending other PR to be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants