Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

add custom_http_statuses option #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtanda
Copy link
Contributor

@mtanda mtanda commented Oct 22, 2020

Fixes #69

I'd tried to use TypeMap, but TypeMap doesn't allow to nest TypeList.
https://discuss.hashicorp.com/t/resource-schema-typelist-as-element-for-typemap/4809

So, I use TypeSet.
I investigate about how to test TypeSet, but I can't find the good method. I didn't add test code...

@dlecan
Copy link

dlecan commented Dec 18, 2020

Someone to review this PR?
I'm interested!

@yktakaha4
Copy link

I thought it was a very good fix, so I created a PR based on it with additional tests at vexxhost#21

@yktakaha4
Copy link

PR has been merged with this provider.
https://github.com/lapras-inc/terraform-provider-uptimerobot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to support custom_http_statuses?
3 participants