This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Monitor data source #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@louy could you please have a look at this PR? |
|
Any chance we could add tests for this? |
|
sure, on it |
evansmurithi
force-pushed
the
add-uptimerobot-monitor-data-source
branch
from
2cc63cb to
e8b0bb3
Compare
|
@louy it's ready for review now |
louy
suggested changes
Oct 29, 2020
| } | ||
|
|
||
| func dataSourceMonitorRead(d *schema.ResourceData, m interface{}) error { | ||
| monitors, err := m.(uptimerobotapi.UptimeRobotApiClient).GetMonitors() |
There was a problem hiding this comment.
Is this the most efficient way to get a single monitor? Why not iterate over the list checking IDs only, and the build the Monitor object only for that single monitor we're interested in?
There was a problem hiding this comment.
Makes sense. Refactored to return monitor IDs that match the provided friendly_name
evansmurithi
force-pushed
the
add-uptimerobot-monitor-data-source
branch
from
e8b0bb3 to
0a1d497
Compare
|
So I'm just wondering, would it make sense to use the |
|
Yeah, that would actually return few records to sift through |
|
@louy updated to use the |
|
@louy should be ready for review |
Compare page offset to total monitor records to know when to break from loop. This will avoid infinit loops in situations where a monitor gets added/removed mid-call.
Avoid constructing Monitor struct for each and every monitor record. Return IDs of monitor records that match the friendly name provided and build the Monitor object for the single monitor found.
Leverage the search parameter in getMonitors API so as to get filtered results instead of getting all monitors
evansmurithi
force-pushed
the
add-uptimerobot-monitor-data-source
branch
from
c4fc6ef to
131f2dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91