Crash in love::graphics::opengl::Canvas::setupGrab

[slime73]

Original report by Pavol Rusnak (Bitbucket: prusnak, GitHub: prusnak).

---

I was experimenting with pixel shaders feature and encountered a crash in love::graphics::opengl::Canvas::setupGrab.

Attaching main.lua and output from adb logcat.

[slime73]

Original comment by Pavol Rusnak (Bitbucket: prusnak, GitHub: prusnak).

---

Crash happens also when used canvases have the same size as the main window, i.e. when one uses

width, height = love.window.getWidth(), love.window.getHeight()
c = love.graphics.newCanvas(width,height)

instead of

c = love.graphics.newCanvas(800,600)

[slime73]

Original comment by Alex Szpakowski (Bitbucket: slime73, GitHub: slime73).

---

The android fork might need to get the latest changes from the GLES branch in love-experiments, I've fixed some things.

[slime73]

Original comment by Martin Felis (Bitbucket: MartinFelis, GitHub: MartinFelis).

---

Unfortunately I cannot reproduce your crash. Actually I cannot even get it to run on the desktop.

I guess the problem is not related to newCanvas, instead it has something to do with the shaders. The attached main.lua (the simple newCanvas example from the Löve wiki) works on my phone and on Desktop. Can you check with this file?

Also I have updated the Löve code to the newest GLES branch in case it is related.

edit: Just re-read that the problems are not related to newCanvas. Nevertheless I cannot get your main.lua to work on Desktop.

[slime73]

Original comment by Pavol Rusnak (Bitbucket: prusnak, GitHub: prusnak).

---

I encounter the same crash with your example. I furthered reduced the testcase to:

function love.load()
    canvas = love.graphics.newCanvas(100, 100)
    love.graphics.setCanvas(canvas)
end

which crashes. This code is OK:

function love.load()
    canvas = love.graphics.newCanvas(100, 100)
end

So it seems, the issue is in setCanvas not newCanvas.

The problem is the same when I use 128x128 canvas, so this is not a power-of-two issue.

[slime73]

Original comment by Martin Felis (Bitbucket: MartinFelis, GitHub: MartinFelis).

---

In alpha6 (http://fysx.org/~martin/shared/love_android_sdl2_alpha6.apk) it does not crash, however I do get a OpenGL error:

#!python


W/Adreno-ES20( 7386): <core_glDiscardFramebufferEXT:3592>: GL_INVALID_ENUM

P.S.: maybe you can join the Löve irc chat?

[slime73]

Original comment by Alex Szpakowski (Bitbucket: slime73, GitHub: slime73).

---

That'd be my bad.

[slime73]

Original comment by Pavol Rusnak (Bitbucket: prusnak, GitHub: prusnak).

---

Commit ab51b4c fixes the issue. Thanks!

[slime73]

Original comment by Pavol Rusnak (Bitbucket: prusnak, GitHub: prusnak).

---

Commit ab51b4c fixes the issue. Thanks!