Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow density values above 2400 dpi #2348

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

stefanprobst
Copy link
Contributor

currently, density is capped at 2400dpi. when e.g. converting svg images with a small viewBox or small width/height values to png images, this can be not enough to produce crisp results.

according to this comment librsvg supports values up to 100000, which is what this PR allows.

my main motivation here is actually not even image quality but file size, i'm seeing 100243 bytes with the density cap, vs 22262 bytes without.

(not sure though if this has any consequences i'm not aware of, or what the original reason for the 2400dpi cap was)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b794669 on stefanprobst:fix/density-dpi into d406cb6 on lovell:master.

@lovell lovell merged commit 79f476a into lovell:master Sep 2, 2020
@lovell
Copy link
Owner

lovell commented Sep 2, 2020

Thank you very much!

lovell added a commit that referenced this pull request Sep 2, 2020
@lovell lovell added this to the v0.26.1 milestone Sep 2, 2020
@stefanprobst stefanprobst deleted the fix/density-dpi branch September 2, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants