fix: allow density values above 2400 dpi #2348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently,
density
is capped at 2400dpi. when e.g. converting svg images with a small viewBox or small width/height values to png images, this can be not enough to produce crisp results.according to this comment
librsvg
supports values up to 100000, which is what this PR allows.my main motivation here is actually not even image quality but file size, i'm seeing 100243 bytes with the density cap, vs 22262 bytes without.
(not sure though if this has any consequences i'm not aware of, or what the original reason for the 2400dpi cap was)