Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for negative top/left offsets in composite overlays, updated #2391

Closed
wants to merge 3 commits into from
Closed

Allow for negative top/left offsets in composite overlays, updated #2391

wants to merge 3 commits into from

Conversation

manan-jadhav
Copy link
Contributor

@manan-jadhav manan-jadhav commented Oct 1, 2020 •
edited
Loading

Composite overlays can be negatively offset, as requested in #1160.

Potentially breaking changes:

  • A top or left offset value of -1 will no longer mean that the value is not set, but will now be an actual offset of -1
  • INT_MIN is now used as the special value instead of -1

Co-authored-by: Christian Flintrup chr@gigahost.dk

This PR extends the work done in #2071

@manan-jadhav @christianflintrup
Allow for negative top/left offsets in composite overlays
b9a2a88 
A top or left offset value of -1 will no longer mean that the value is not set, but will now be an actual offset of -1

INT_MIN for left & top will mean that the values are not set

Co-authored-by: Christian Flintrup <chr@gigahost.dk>
@coveralls
Copy link

coveralls commented Oct 1, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4f2801b on CurosMJ:master into 3ec281d on lovell:master.

lovell
lovell requested changes Oct 7, 2020
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for updating this PR Manan, I've left a couple of questions inline.

test/unit/composite.js Show resolved Hide resolved
src/pipeline.h Outdated Show resolved Hide resolved
@manan-jadhav
remove IsUndefined check,
1aa2e4d 
rely on Javascript provided hasOffset property to
determine if offset is to be applied,
add removed tests, fixed comments
@manan-jadhav
merge duplicate tests
4f2801b
lovell
lovell approved these changes Oct 7, 2020
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates Manan, this is ready to merge. Given it contains a slightly breaking change it's probably best to wait and include this in v0.27.0, so please bear with me whilst I get v0.26.2 out of the door first.

@lovell lovell added this to the v0.27.0 milestone Oct 7, 2020
@lovell lovell mentioned this pull request Oct 7, 2020
Closed
@master117
Copy link

Will this also allow top/left that would move the image partially outside on the right or bottom?

@lovell
Copy link
Owner

lovell commented Dec 20, 2020

Landed as 0267614 - thanks all, this will be in v0.27.0

@lovell lovell closed this Dec 20, 2020
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell lovell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@manan-jadhav @coveralls @master117 @lovell