Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to better reflect output of RAW data #499

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Update docs to better reflect output of RAW data #499

merged 2 commits into from
Jul 7, 2016

Conversation

mhirsch
Copy link
Contributor

@mhirsch mhirsch commented Jul 7, 2016

Tiny pr to document something that I initially found confusing. I expected

sharp(input).raw().toFile('c.raw');

to write a raw dump of the image in uint8, but instead I get an error:

Unhandled rejection Error: Unsupported output format c.raw
    at Error (native)

@@ -500,7 +500,7 @@ A Promises/A+ promise is returned when `callback` is not provided.

#### toBuffer([callback])

Write image data to a Buffer, the format of which will match the input image by default. JPEG, PNG and WebP are supported.
Write image data to a Buffer, the format of which will match the input image by default. JPEG, PNG WebP, and RAW are supported.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you move the comma :)

@lovell
Copy link
Owner

lovell commented Jul 7, 2016

Thanks. Perhaps raw file output should be made available? Feel free to open a new issue if you need this.

@mhirsch
Copy link
Contributor Author

mhirsch commented Jul 7, 2016

I don't particularly need that feature right now. Nice to have it documented. Thanks for your feedback!

@lovell lovell merged commit a982cfd into lovell:master Jul 7, 2016
@lovell lovell added this to the v0.15.1 milestone Jul 7, 2016
@mhirsch mhirsch deleted the raw_doc_update branch July 7, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants