[CI] Remove signed off IPs from the register module checker #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imphil
reviewed
Nov 13, 2019
azure-pipelines.yml
Outdated
| @@ -42,7 +42,7 @@ jobs: | |||
| # displayName: 'Run Python lint' | |||
|
|
|||
| - bash: | | |||
| make -C hw regs && git diff --exit-code | |||
| make -C hw regs && git restore -- hw/ip/gpio hw/ip/uart hw/ip/rv_timer && git diff --exit-code | |||
There was a problem hiding this comment.
How about removing these modules from the hw makefile instead of reverting the check here?
And please explicitly comment them out and add a comment referring to an issue explaining what's going on. Autogenerated files in the tree which are actually not auto-generated are problematic.
There was a problem hiding this comment.
Thanks. I've changed hw/Makefile rather than azure-pipelines.yml
eunchan
force-pushed
the
signedoff
branch
2 times, most recently
from
10b36a8
to
d2417df
Compare
imphil
approved these changes
Nov 13, 2019
|
Thanks @eunchan! |
This is temporary fix until the IP versioning discussion is completed. As PR lowRISC#965 merged, the Azure Pipeline failed on newer PRs. ```log Build log #L1010 Register headers not up-to-date. Regenerate them with 'make -C hw regs'. ``` PR lowRISC#965 didn't include `gpio`, `uart`, `rv_timer` from the collaterals as those IPs were signed off ( lowRISC#676 lowRISC#615 lowRISC#652 ). The azure pipeline checks every IPs' generated register modules. It is good as it can catch this case, which prevents silent upgrade of internal modules in the signed-off IPs. But it is also annoying every PRs from now failed. So, temporary `hw/Makefile` ignores signed-off IPs until better IP versioning rule is suggested. This is related to lowRISC#975 Signed-off-by: Eunchan Kim <eunchan@opentitan.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporary fix until the IP versioning discussion is completed.
As PR #965 merged, the Azure Pipeline failed on newer PRs.
PR #965 didn't include
gpio,uart,rv_timerfrom the collateralsas those IPs were signed off ( #676 #615 #652 ). The azure pipeline
checks every IPs' generated register modules.
It is good as it can catch this case, which prevents silent upgrade of
internal modules in the signed-off IPs. But it is also annoying every
PRs from now failed.
So, temporary the checker ignores signed-off IPs until better IP
versioning rule is suggested.
This is related to #975