GPIO Signoff#676
Conversation
eunchan
requested review from
aytong,
gaurangchitroda,
sjgitty,
sriyerg and
weicaiyang
|
@gaurangchitroda Could you please update the DV items on top of my working branch (eunchan:gpio_signoff)? |
There was a problem hiding this comment.
@gkelly Could you please update? Do they look good? I think there's not much things related to FATAL_ERR in GPIO..
There was a problem hiding this comment.
@gkelly ping again... It would be good if we can get the feedback today to close this PR.
There was a problem hiding this comment.
@eunchan LGTM on SW_CSR. Are there any FATAL_ERR conditions covered in the register interface?
There was a problem hiding this comment.
Sorry for the delays. I just had a chance to go through again and this LGTM.
aytong
left a comment
aytong
left a comment
There was a problem hiding this comment.
@gaurangchitroda add link to DV plan in V1 section.
|
please add the updated .prj.hjson file to this PR |
@aytong - I have shared path of updated checklist with @eunchan with updates including DV plan link and updates on tasks. |
There was a problem hiding this comment.
@sriyerg - As I mentioned, dv plan needs this update once this PR is merged.
There was a problem hiding this comment.
Hum... Can I just roll it back?
There was a problem hiding this comment.
I don't know why this PR has RTL change or not.. Shouldn't be...
This is temporary fix until the IP versioning discussion is completed. As PR lowRISC#965 merged, the Azure Pipeline failed on newer PRs. ```log Build log #L1010 Register headers not up-to-date. Regenerate them with 'make -C hw regs'. ``` PR lowRISC#965 didn't include `gpio`, `uart`, `rv_timer` from the collaterals as those IPs were signed off ( lowRISC#676 lowRISC#615 lowRISC#652 ). The azure pipeline checks every IPs' generated register modules. It is good as it can catch this case, which prevents silent upgrade of internal modules in the signed-off IPs. But it is also annoying every PRs from now failed. So, temporary `hw/Makefile` ignores signed-off IPs until better IP versioning rule is suggested. This is related to lowRISC#975 Signed-off-by: Eunchan Kim <eunchan@opentitan.org>
6 participants
This is a draft of GPIO checklist document.