Add CWHusky Support (#50) #56

colinoflynn · 2021-10-26T12:22:33Z

This should add support for CW-Husky (#50). The default gain in the .yaml file should change for Husky, around 35 seemed to work for me (this could be changed in the file as well, not sure where makes sense). The CW-Lite gain is low but does work, so it's safer to keep cw-lite gain levels presumably in the code itself.

I can squash these if too many commits (especially somehow realising LFS added the full files so I had to revert them, which I'm not sure why that happened)

alphan

Thanks @colinoflynn, just some minor comments. It would be great if you could squash the commits.

alphan · 2021-10-27T01:46:43Z

cw/cw305/cw_segmented.py

+            if not self.num_segments_min <= num_segments <= self.num_segments_max:
+                raise RuntimeError(
+                    f"num_segments must be in [{self.num_segments_min}, {self.num_segments_max}]."
+                )


I haven't gotten the chance to check the husky API yet but don't we need this bounds check for husky as well?

I'll check - the husky in general does correctly support stuff (since you now specify the segment count).

yeah I think it's a good idea to have the bounds check for Husky too

alphan · 2021-10-27T01:53:51Z

cw/cw305/simple_capture_traces_batch.py

@@ -31,10 +31,8 @@ def create_waverunner(ot, capture_cfg):


 def create_cw_lite_segmented(ot, capture_cfg):
-    # TODO: Remove this disconnect after removing cw-lite init from device.py.
-    ot.scope.dis()
    return CwLiteSegmented(num_samples=capture_cfg["num_samples"],


shouldn't this be CwSegmented(...?

Related to that, also the function name itself should maybe be changed to create_cw_segmented.

CwSegmented

Hmm, yes thanks! Renaming files/classes was my last local step & I undid it at one point, but it left a copy of cw_lite_segmented.py still around (but with husky changes), so I didn't see this error locally. I'll double-check with a fresh checkout both are working.

Related to that, also the function name itself should maybe be changed to create_cw_segmented

Makes sense - will do that too.

alphan · 2021-10-27T02:04:41Z

cw/cw305/simple_capture_traces_batch.py

-    # TODO: Remove this disconnect after removing cw-lite init from device.py.
-    ot.scope.dis()


I can't remember why we had to disconnect and reconnect for cw-lite (could be because we had to re-init to be able to use segmented traces?) but it may be a good idea to handle cw-lite and husky separately here to be safe unless it's not necessary. Something like:

scope = None if not ot.scope._is_husky: # CwSegmented will connect again ot.scope.dis() else: scope = ot.scope CwSegmented(..., scope=scope)

IIRC the issue can come up when you try talking to the CW from two different locations. The ot.scope.dis() error will hit the CW-Lite as well with new firmware however, as basically with the current USB driver the ot.scope.dis() will cause the error mentioned at newaetech/chipwhisperer#362 .

vogelpi

Thanks for creating this PR @colinoflynn and @jpcrypt . I am excited to start working with Husky!

I have two remarks/requests:

Inside ot-sca/python-requirements.txt we were pinning the ChipWhisperer version to newaetech/chipwhisperer@0998072 in order to keep segmented mode alive for CW-Lite. I would assume that for Husky we need the latest version, right? If yes, we should probably unpin the version in the requirements file.
Can you please squash the commits into one?

vogelpi · 2021-10-27T07:33:49Z

cw/cw305/simple_capture_traces_batch.py

@@ -31,10 +31,8 @@ def create_waverunner(ot, capture_cfg):


 def create_cw_lite_segmented(ot, capture_cfg):
-    # TODO: Remove this disconnect after removing cw-lite init from device.py.
-    ot.scope.dis()
    return CwLiteSegmented(num_samples=capture_cfg["num_samples"],


Related to that, also the function name itself should maybe be changed to create_cw_segmented.

colinoflynn · 2021-10-27T12:00:40Z

I'll leave the squashing to the last step once everything else resolved.

On python-requirements.txt I guess that raises one particularly terrible point - CW-Lite + CW-Husky require different CW versions. I'll see if our next rebuild of the CW-Lite fixes segmenting again in which case they'd both work with latest.

But in the meantime I could unpin python-requirements.txt and also add a manual version check inside of the initialisation function that warns the user if they've got an incompatible CW version for now. This would at least reduce user frustration since I think errors from wrong version are very non-obvious (especially for someone just starting).

Signed-off-by: Colin O'Flynn <coflynn@newae.com>

alphan · 2021-10-28T16:17:36Z

I'll leave the squashing to the last step once everything else resolved.

On python-requirements.txt I guess that raises one particularly terrible point - CW-Lite + CW-Husky require different CW versions. I'll see if our next rebuild of the CW-Lite fixes segmenting again in which case they'd both work with latest.

But in the meantime I could unpin python-requirements.txt and also add a manual version check inside of the initialisation function that warns the user if they've got an incompatible CW version for now. This would at least reduce user frustration since I think errors from wrong version are very non-obvious (especially for someone just starting).

Obviously having both working until everyone successfully transitions to CW-Husky is ideal but if this check will take considerable effort I would suggest just unpinning and printing a warning in CWSegmented::__init__(). Not sure if we need a version check since I would expect folks to update their dependencies after this PR merged or CW-Husky wouldn't work otherwise, right? We should also announce this in the SCA meeting of course.

colinoflynn · 2021-10-28T16:23:01Z

but if this check will take considerable effort I would suggest just unpinning and printing a warning

Ah I did add that check sorry but forgot to add this back - it's not perfect as the older version doesn't support CW-Husky so it doesn't warn you about trying to use CW-Husky with the old version (but that fails anyway). I think the bigger threat is someone trying to get CW-Lite working on the "new" version, which it warns you about.

Signed-off-by: jpcrypt <jpthibault@newae.com>

m-temp · 2021-11-02T13:35:52Z

I'll leave the squashing to the last step once everything else resolved.

On python-requirements.txt I guess that raises one particularly terrible point - CW-Lite + CW-Husky require different CW versions. I'll see if our next rebuild of the CW-Lite fixes segmenting again in which case they'd both work with latest.

But in the meantime I could unpin python-requirements.txt and also add a manual version check inside of the initialisation function that warns the user if they've got an incompatible CW version for now. This would at least reduce user frustration since I think errors from wrong version are very non-obvious (especially for someone just starting).

Hi,
first of all: thanks for the work on the husky support.
Unpinning the cw version currently leads to cw 5.6.1 which requires python3.7 (at least it says so in the setup.py), which is not the default in ubuntu 18.04 LTS and thus, requires a python update. This is for sure doable, but in general ubuntu 18.04 lts + python3.6 is recommended for opentitan. Is there a version that supports the husky and python3.6? Or can the python_requires='~=3.7' be softened?

colinoflynn · 2021-11-02T15:08:29Z

I checked with @alex-dewar - this is a follow-on from numpy, which started requiring 3.7 (https://numpy.org/neps/nep-0029-deprecation_policy.html). There is no critical numpy features we needed from latest, so you can just use whatever version of numpy comes with 3.6 and it should work.

m-temp

I could successfully reproduce the AES attack described at https://github.com/newaetech/ot-sca/blob/cwhusky-doc/doc/getting_started_bergen.md using the the cw310 and husky.

One minor point:

There is a API warning: WARNING:ChipWhisperer Other:Could not check ChipWhisperer version, error __init__() got an unexpected keyword argument 'capture_output'

Signed-off-by: jpcrypt <jpthibault@newae.com>

colinoflynn requested review from alphan, moidx and vogelpi as code owners October 26, 2021 12:22

moidx requested a review from m-temp October 27, 2021 00:58

moidx approved these changes Oct 27, 2021

View reviewed changes

alphan approved these changes Oct 27, 2021

View reviewed changes

vogelpi approved these changes Oct 27, 2021

View reviewed changes

Add CW-Husky support

eac822f

Signed-off-by: Colin O'Flynn <coflynn@newae.com>

colinoflynn force-pushed the cwhusky-support branch from a9242bc to eac822f Compare October 27, 2021 16:11

Add OTBN trace capture notebook.

8580ee0

Signed-off-by: jpcrypt <jpthibault@newae.com>

m-temp approved these changes Nov 3, 2021

View reviewed changes

jpcrypt added 2 commits November 11, 2021 14:45

update notebooks

917751c

Signed-off-by: jpcrypt <jpthibault@newae.com>

update notebooks

94bfe3a

Signed-off-by: jpcrypt <jpthibault@newae.com>

moidx merged commit 5997c24 into lowRISC:master Dec 8, 2021

vogelpi mentioned this pull request Dec 24, 2021

Add support for CW-Husky #50

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CWHusky Support (#50) #56

Add CWHusky Support (#50) #56

colinoflynn commented Oct 26, 2021

alphan left a comment

alphan Oct 27, 2021

colinoflynn Oct 28, 2021

jpcrypt Oct 28, 2021

alphan Oct 27, 2021

vogelpi Oct 27, 2021

colinoflynn Oct 27, 2021

alphan Oct 27, 2021

colinoflynn Oct 27, 2021

vogelpi left a comment

vogelpi Oct 27, 2021

colinoflynn commented Oct 27, 2021

alphan commented Oct 28, 2021

colinoflynn commented Oct 28, 2021

m-temp commented Nov 2, 2021

colinoflynn commented Nov 2, 2021 •

edited

Loading

m-temp left a comment

		# TODO: Remove this disconnect after removing cw-lite init from device.py.
		ot.scope.dis()

Add CWHusky Support (#50) #56

Add CWHusky Support (#50) #56

Conversation

colinoflynn commented Oct 26, 2021

alphan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vogelpi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colinoflynn commented Oct 27, 2021

alphan commented Oct 28, 2021

colinoflynn commented Oct 28, 2021

m-temp commented Nov 2, 2021

colinoflynn commented Nov 2, 2021 • edited Loading

m-temp left a comment

Choose a reason for hiding this comment

colinoflynn commented Nov 2, 2021 •

edited

Loading