Skip to content

[Fix]: #1965 chart expanded in table rows binding #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Fix]: #1965 chart expanded in table rows binding #2008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions client/packages/lowcoder/src/comps/generators/withSelectedMultiContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,35 +73,43 @@ export function withSelectedMultiContext<TCtor extends MultiCompConstructor>(
comp.getOriginalComp().setParams(comp.cacheParamsMap.get(selection)!)
);
}
} else if ((
!action.editDSL
&& !isCustomAction<LazyCompReadyAction>(action, "LazyCompReady")
&& !isCustomAction<RemoteCompReadyAction>(action, "RemoteCompReady")
&& !isCustomAction<ModuleReadyAction>(action, "moduleReady")
) || action.path[0] !== MAP_KEY || _.isNil(action.path[1])
) {
if (action.path[0] === MAP_KEY && action.path[1] === SELECTED_KEY) {
action.path[1] = this.selection;
}
comp = super.reduce(action);
} else if ((
action.editDSL
|| isCustomAction<LazyCompReadyAction>(action, "LazyCompReady")
|| isCustomAction<RemoteCompReadyAction>(action, "RemoteCompReady")
|| isCustomAction<ModuleReadyAction>(action, "moduleReady")
) && (
action.path[1] === SELECTED_KEY
|| ( // special check added for modules inside list view
|| (
isCustomAction<ModuleReadyAction>(action, "moduleReady")
&& action.path[1] === this.selection)
)) {
// broadcast
// broadcast edits from the selected design-time view to all instances and template
const newAction = {
...action,
path: action.path.slice(2),
};
comp = comp.reduce(WithMultiContextComp.forEachAction(newAction));
comp = comp.reduce(wrapChildAction(COMP_KEY, newAction));
} else if (
// ensure edits made in the expanded view configurator (SELECTED key)
// also update the template
action.path[0] === MAP_KEY && action.path[1] === SELECTED_KEY
) {
const newAction = {
...action,
path: action.path.slice(2),
};
comp = comp.reduce(WithMultiContextComp.forEachAction(newAction));
comp = comp.reduce(wrapChildAction(COMP_KEY, newAction));
} else if ((
!action.editDSL
&& !isCustomAction<LazyCompReadyAction>(action, "LazyCompReady")
&& !isCustomAction<RemoteCompReadyAction>(action, "RemoteCompReady")
&& !isCustomAction<ModuleReadyAction>(action, "moduleReady")
) || action.path[0] !== MAP_KEY || _.isNil(action.path[1])
) {
comp = super.reduce(action);
} else if (
!action.editDSL
&& (
Expand All @@ -112,8 +120,6 @@ export function withSelectedMultiContext<TCtor extends MultiCompConstructor>(
) {
comp = super.reduce(action);
}

// console.info("exit withSelectedMultiContext reduce. action: ", action, "\nthis:", this, "\ncomp:", comp);
return comp;
}

Expand Down
Loading