Skip to content

Dev #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Dev #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e1739
fix: browser-check not generated
Oct 21, 2023
b62739d
Merge pull request #427 from lowcoder-org/frontend-fixes
FalkWolsky Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/packages/lowcoder/src/comps/utils/useCompInstance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export function getCompContainer<T extends CompConstructor>(params: GetContainer
const reduceFn = wrapWithPromiseHandling((act: CompAction) => {
let action = act;
if (reduceContext && reduceContext.readOnly && action.editDSL) {
log.error("editDSL should be false in view mode, action: ", action);
log.info("editDSL should be false in view mode, action: ", action);
action = { ...action, editDSL: false };
}

Expand Down
4 changes: 3 additions & 1 deletion client/packages/lowcoder/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ const isEEGlobal = edition === "enterprise-global";
const isEE = edition === "enterprise" || isEEGlobal;
const isDev = nodeEnv === "development";
const isVisualizerEnabled = !!process.env.ENABLE_VISUALIZER;
const browserCheckFileName = `browser-check-${process.env.REACT_APP_COMMIT_ID}.js`;
// the file was never created
// const browserCheckFileName = `browser-check-${process.env.REACT_APP_COMMIT_ID}.js`;
const browserCheckFileName = `browser-check.js`;
const base = ensureLastSlash(process.env.PUBLIC_URL);

if (!apiProxyTarget && isDev) {
Expand Down