Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check definition of uart status register #59

Closed
mdhayter opened this issue May 21, 2019 · 3 comments
Closed

Check definition of uart status register #59

mdhayter opened this issue May 21, 2019 · 3 comments
Assignees
Labels

Comments

@mdhayter
Copy link
Contributor

Verilator gives a warning:
%Warning-UNUSED: ../src/lowrisc_ip_uart_0.1/rtl/uart_core.sv:12: Bits of signal are not used: reg2hw[99:88]

This corresponds to the q and re bits for the status register. Should the register be declared hwo and not have hwre set? (I think at one point there were some read side-effects)

@tjaychen
Copy link

@eunchan
do you mind taking a look? Just wondering if this falls under the things we should clean up for uart hero.

@weicaiyang FYI

@eunchan
Copy link
Contributor

eunchan commented Sep 23, 2019

This looks like waived in the lint and it is OK as it is now. A few of the fields in the register are used in the design

@tjaychen
Copy link

tjaychen commented Sep 23, 2019 via email

@eunchan eunchan closed this as completed Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants