samba.c: popen() leaks via stderr #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
lpereira
reviewed
Aug 16, 2017
| gsize length; | ||
|
|
||
| spawned = g_spawn_command_line_sync("net usershare list", | ||
| &out, &err, &status, NULL); |
There was a problem hiding this comment.
If stderr is not required, you can pass NULL instead of &err; then there's no need to free() it below.
There was a problem hiding this comment.
It appears that if you pass NULL, then stderr will still leak.
There was a problem hiding this comment.
If it's leaking, it's a bug in GLib. It's marked as optional in the documentation.
There was a problem hiding this comment.
If NULL is passed, the following message appears in Terminal when Shared Directories is selected:
net usershare: cannot open usershare directory /var/lib/samba/usershares. Error No such file or directory
Please ask your system administrator to enable user sharing.
I don't know, but I think it could still be optional and just forward stderr to the application's stderr if it is NULL.
When it is captured in a string, the message does not appear in Terminal.
lpereira
requested changes
Aug 16, 2017
bp0
force-pushed
the
popen-samba
branch
2 times, most recently
from
0ca5ae0
to
9ff175a
Compare
Signed-off-by: Burt P <pburt0@gmail.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #162: Change samba.c to use g_spawn_command_line_sync() instead of popen() to prevent leaks via stderr.
Prevents this message from appearing:
The problem is that I have no "usershares", so I didn't test if it is otherwise still working. Will someone who does test that?