-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated code lifecycle
: Add access log for repositories
#9184
Conversation
Development
: Log access to LocalVC repositoriesDevelopment
: Create access log for LocalVC repositories
src/main/resources/config/liquibase/changelog/20240804144500_changelog.xml
Outdated
Show resolved
Hide resolved
src/main/resources/config/liquibase/changelog/20240804144500_changelog.xml
Outdated
Show resolved
Hide resolved
src/main/resources/config/liquibase/changelog/20240804144500_changelog.xml
Outdated
Show resolved
Hide resolved
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Development
: Create access log for LocalVC repositoriesDevelopment
: Add access log for LocalVC repositories
WalkthroughThe changes introduce a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Service as ProgrammingExerciseParticipationService
participant Component as VcsRepositoryAccessLogViewComponent
participant LogRepo as VcsAccessLogRepository
User->>Component: Request VCS Access Logs
Component->>Service: Get VCS Access Log for Participation
Service->>LogRepo: Retrieve Logs by Participation ID
LogRepo-->>Service: Return Logs
Service-->>Component: Provide Logs
Component-->>User: Display VCS Access Logs
sequenceDiagram
participant User
participant RepoService as RepositoryService
participant LogService as VcsAccessLogService
User->>RepoService: Commit Changes
RepoService->>LogService: Store Code Editor Access Log
LogService-->>RepoService: Log Stored
RepoService-->>User: Changes Committed
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/main/java/de/tum/in/www1/artemis/domain/vcstokens/VcsAccessLog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
Development
: Add access log for LocalVC repositoriesIntegrated code lifecycle
: Add access log for LocalVC repositories
Integrated code lifecycle
: Add access log for LocalVC repositoriesIntegrated code lifecycle
: Add access log for repositories
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Changes affecting Programming Exercises
Motivation and Context
Similar to gitlab we want to be able to log accesses to LocalVC repositories. Especially knowing the pushing user, and the IP address could help to prevent fraud (e.g. during exams). Further this helps us quantitively see, which authentication mechanisms users use (SSH, password or tokens).
We want to show these logs to instructors of a course/exercise. This UI will be implemented in a follow up.
Description
This PR adds a access log for LocalVC repositories. When a user pushes or pulls, a log entry is written to the database.
An entry in the new access log table contains:
-> see screenshot below
Steps for Testing
This change should have no visible effect.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
The vcs-access-log button in the code editor (repository view):
The new vcs-access-log page:
In the database:
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes