Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTP: Fixed lgetxattr02 testcase #36

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Conversation

vamsikrishna935
Copy link

@vamsikrishna935 vamsikrishna935 commented Jul 31, 2020

  • Patch Description:
    Test failure reason in SGX-LKL:
    [[ SGX-LKL ]] libc_start_main_stage2(): Calling app main: /ltp/testcases/kernel/syscalls/lgetxattr/lgetxattr02
    tst_test.c:1106: INFO: Timeout per run is 0h 05m 00s
    tst_test.c:1125: INFO: No fork support
    lgetxattr02.c:78: CONF: no xattr support in fs or mounted without user_xattr option

  • Workaround to fix the issue:
    Modified the tests to use root filesystem.
    Disabled a test, which needs to be enabled once git issue [Tests] lkl_access_ok() should return failure on test invalid access, not fatal exit. sgx-lkl#297 is fixed

Copy link
Collaborator

@hukoyu hukoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vamsikrishna935 general looks good. Please just add more detailed comment as I requested. Thanks

testcases/kernel/syscalls/lgetxattr/lgetxattr02.c Outdated Show resolved Hide resolved
@SeanTAllen
Copy link

This needs a corresponding PR on sgx-lkl so that CI is run with this change. Please speak to @hukoyu if you aren't familiar with how to do that.

@SeanTAllen
Copy link

SeanTAllen commented Aug 6, 2020

Why does it need to use the root filesystem? This might be a bug that can be fixed rather than patching tests.

@vamsikrishna935
Copy link
Author

Why does it need to use the root filesystem? This might be a bug that can be fixed rather than patching tests.

@SeanTAllen : Logged an issue : lsds/sgx-lkl#736

@hukoyu
Copy link
Collaborator

hukoyu commented Aug 6, 2020

lsds/sgx-lkl#727 fixes the issue 297. When it is merged we will not need to disable test.
Also let's wait result of lsds/sgx-lkl#736 for xattr attribute for /tmp.

@hukoyu hukoyu changed the title LTP: Fixed lgetxattr02 testcase Don't merge LTP: Fixed lgetxattr02 testcase Aug 6, 2020
@hukoyu
Copy link
Collaborator

hukoyu commented Aug 11, 2020

@vamsikrishna935 lsds/sgx-lkl#297 is fixed and merged. Please revert 297 related changes from this PR.

@vamsikrishna935
Copy link
Author

@vamsikrishna935 lsds/sgx-lkl#297 is fixed and merged. Please revert 297 related changes from this PR.

@hukoyu Done.
@davidchisnall Could you please review

Copy link
Collaborator

@hukoyu hukoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hukoyu hukoyu requested a review from SeanTAllen August 12, 2020 05:09
@hukoyu hukoyu merged commit dfe3080 into lsds:sgx-lkl Aug 12, 2020
@hukoyu hukoyu changed the title Don't merge LTP: Fixed lgetxattr02 testcase LTP: Fixed lgetxattr02 testcase Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants