-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTP: Fixed lgetxattr02 testcase #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vamsikrishna935 general looks good. Please just add more detailed comment as I requested. Thanks
This needs a corresponding PR on sgx-lkl so that CI is run with this change. Please speak to @hukoyu if you aren't familiar with how to do that. |
Why does it need to use the root filesystem? This might be a bug that can be fixed rather than patching tests. |
@SeanTAllen : Logged an issue : lsds/sgx-lkl#736 |
lsds/sgx-lkl#727 fixes the issue 297. When it is merged we will not need to disable test. |
@vamsikrishna935 lsds/sgx-lkl#297 is fixed and merged. Please revert 297 related changes from this PR. |
@hukoyu Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Patch Description:
Test failure reason in SGX-LKL:
[[ SGX-LKL ]] libc_start_main_stage2(): Calling app main: /ltp/testcases/kernel/syscalls/lgetxattr/lgetxattr02
tst_test.c:1106: INFO: Timeout per run is 0h 05m 00s
tst_test.c:1125: INFO: No fork support
lgetxattr02.c:78: CONF: no xattr support in fs or mounted without user_xattr option
Workaround to fix the issue:
Modified the tests to use root filesystem.
Disabled a test, which needs to be enabled once git issue [Tests] lkl_access_ok() should return failure on test invalid access, not fatal exit. sgx-lkl#297 is fixed