Don't merge LTP: Fixed get_robust_list01 testcase #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you hold off on this one? @KenGordon has a fix for lsds/sgx-lkl#297 that should eliminate the need for this. |
|
This needs a corresponding PR on sgx-lkl so that CI is run with this change. Please speak to @hukoyu if you aren't familiar with how to do that. |
|
After lsds/sgx-lkl#727 is merged, we will not need this patch. |
hukoyu
changed the title
|
Submitted PR lsds/sgx-lkl#765 and this test is passing as is. This patch not needed. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of sub tests (EFAULT) is failing because of [Tests] lkl_access_ok() should return failure on test invalid access, not fatal exit. sgx-lkl#297
Issue 297: [Tests] lkl_access_ok() should return -1 on invalid access
Commented the test related 297 issue and added a todo comment