-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTP: fix test case writev06 issue #58
Conversation
Below issues are found in this test case: 1. mmap is failing with EBADF error if we pass 0 as file descriptor with MAP_ANONYMOUS option. 2. TPASS message is tagged as INFO message. Below modifications are performed. 1. Modified the test case to pass -1 as a file descriptor value while invoking mmap. 2. Modified the print message TAG to TPASS.
I think the third bullet point is a real bug (@SeanTAllen, can you take a look?). In POSIX it is undefined what happens when you |
@davidchisnall here's the code: // Anonymous mapping/allocation
else if (fd == -1 && (flags & MAP_ANONYMOUS))
{
return (long)enclave_mmap(addr, length, flags & MAP_FIXED, prot, 1);
} So yes, MAP_ANONYMOUS is only supported currently if the fd is -1. Shall we change to ignore the fd entirely? |
@davidchisnall assuming a yes, I went ahead and created lsds/sgx-lkl#755 |
@shaikshavali1, please revert the corresponding changes in this PR. @hukoyu, once lsds/sgx-lkl#755 is merged, please go ahead and merge the version of this without those changes. |
lsds/sgx-lkl#755 has been merged. |
Submitted PR lsds/sgx-lkl#765 to enable this test as is without patch and it is passing. This patch not needed anymore. Closing. |
Below issues are found in this test case:
with MAP_ANONYMOUS option.
Below modifications are performed.
while invoking mmap.