-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTP: Fixed renameat01 testcase #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are these changes needed now that we have a temporary device for LTP tests? |
@davidchisnall : are you talking about this lsds/sgx-lkl#764 , if it enables temporary device then we don't need these changes. Only one needs to be remove tst_mkfs function. I will do changes as necessary. |
@vamsikrishna935 revert your changes and disable tst_mkfs as you mentioned. Assume lsds/sgx-lkl#764 will be merged. |
Done |
@davidchisnall Could you please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantic nit: system
is not a syscall, it's a libc call, it uses fork/vfork/clone + execve system calls.
Tests were failing with Kernel panic(out of memory) in loop device.
In loop device we have memory limit of 32MB.
So modified the tests to use root file system.
Commented subtest EROFS which verifies read-only file system because
as root file system is mounted with write-only mode this cannot be tested