LTP: Fixed unshare01 and unshare02

[vamsikrishna935]

• Patch Description:
  Test were failing because of no fork support.
  Modified the tests without using fork and done code cleanup.

[hukoyu]

LGTM

[davidchisnall]

I don't understand this patch. Unshare's behaviour is intrinsically linked to multiple processes, so we should just disable this test.

[vamsikrishna935]

I don't understand this patch. Unshare's behaviour is intrinsically linked to multiple processes, so we should just disable this test.

@davidchisnall can we implement this using threads ?
Manpage statement : unshare() allows a process (or thread) to disassociate parts of its
execution context that are currently being shared with other
processes (or threads).

[davidchisnall]

I’m not sure what man page you’re reading, but the one I have does not mention threads. That said, the design doc for unshare indicates it applies to threads created with clone. I have no idea whether this will work correctly until Vikas’ patch lands, but it looks as if it should be possible to enable this with threads.

[davidchisnall]

I think these changes are okay, the test itself is pretty useless: it tests that the syscall returns success, not that it actually does anything.