remove redundant checks from simple_ensemble

these are already performed by `validate_model_output_df`

R/simple_ensemble.R

@@ -67,20 +67,16 @@ simple_ensemble <- function(model_outputs, weights = NULL,
     task_id_cols <- model_out_cols[!model_out_cols %in% non_task_cols]
   }
 
-  req_col_names <- c(non_task_cols, task_id_cols)
-  if (!all(req_col_names %in% model_out_cols)) {
+  if (!all(task_id_cols %in% model_out_cols)) {
     cli::cli_abort(c(
-      "x" = "{.arg model_outputs} did not have all required columns
-             {.val {req_col_names}}."
+      "x" = "{.arg model_outputs} did not have all listed task id columns
+             {.val {task_id_col}}."
     ))
   }
-
-  ## Validations above this point to be relocated to hubUtils
-  # hubUtils::validate_model_output_df(model_outputs)
-
-  if (nrow(model_outputs) == 0) {
-    cli::cli_warn(c("!" = "{.arg model_outputs} has zero rows."))
-  }
+
+  # check `model_outputs` has all standard columns with correct data type
+  # and `model_outputs` has > 0 rows
+  hubUtils::validate_model_output_df(model_outputs)
 
   valid_types <- c("mean", "median", "quantile", "cdf", "pmf")
   unique_types <- unique(model_outputs[[output_type_col]])