Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the test cases that are removed when removing generics in #37 #131

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Oct 1, 2023

This pull request brings back the test cases that are removed when removing generics in #37.

Also:

  • fixed the SOrd instance for VerificationConditions,
  • fixed the missing SubstituteSym instance for UnionM,
  • fixed the symbolic variable generation order for Maybe.

@lsrcz lsrcz force-pushed the revive-lib-tests branch 2 times, most recently from 305fca0 to 19ccaa3 Compare October 1, 2023 08:18
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Grisette/Core/Control/Exception.hs 80.00% <100.00%> (+66.66%) ⬆️
src/Grisette/Core/Control/Monad/UnionM.hs 69.30% <ø> (+58.77%) ⬆️
src/Grisette/Core/Data/Class/GenSym.hs 55.06% <50.00%> (+50.41%) ⬆️

... and 25 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

…#37

Fixed the SOrd instance for VerificationConditions, fixed the missing SubstituteSym instance for UnionM, fixed the symbolic variable generation order for Maybe.
@lsrcz lsrcz merged commit ac22c5c into main Oct 1, 2023
24 checks passed
@lsrcz lsrcz deleted the revive-lib-tests branch October 1, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant