Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the internal representation of terms. #193

Merged
merged 24 commits into from
Apr 19, 2024
Merged

Refactor the internal representation of terms. #193

merged 24 commits into from
Apr 19, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Apr 18, 2024

This pull request refactored the old, ugly code for the terms. This will make it easier to add new term types.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 52.78211% with 908 lines in your changes are missing coverage. Please review.

Project coverage is 58.83%. Comparing base (699151e) to head (5e6e740).

❗ Current head 5e6e740 differs from pull request most recent head 9c6471a. Consider uploading reports for the commit 9c6471a to get more accurate results

Files Patch % Lines
src/Grisette/IR/SymPrim/Data/GeneralFun.hs 19.36% 240 Missing and 14 partials ⚠️
src/Grisette/IR/SymPrim/Data/TabularFun.hs 11.40% 181 Missing and 21 partials ⚠️
src/Grisette/IR/SymPrim/Data/Prim/Internal/Term.hs 73.56% 41 Missing and 60 partials ⚠️
src/Grisette/IR/SymPrim/Data/SymBV.hs 50.44% 33 Missing and 23 partials ⚠️
src/Grisette/IR/SymPrim/Data/AllSyms.hs 3.50% 55 Missing ⚠️
src/Grisette/Backend/SBV/Data/SMT/Solving.hs 74.00% 6 Missing and 33 partials ⚠️
...IR/SymPrim/Data/Prim/Internal/Instances/BVPEval.hs 65.30% 0 Missing and 34 partials ⚠️
...Prim/Data/Prim/Internal/Instances/SupportedPrim.hs 46.66% 17 Missing and 15 partials ⚠️
src/Grisette/IR/SymPrim/Data/SymGeneralFun.hs 34.61% 16 Missing and 1 partial ⚠️
src/Grisette/IR/SymPrim/Data/SymTabularFun.hs 23.80% 15 Missing and 1 partial ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   59.76%   58.83%   -0.94%     
==========================================
  Files          71       79       +8     
  Lines        6224     6500     +276     
  Branches      505      626     +121     
==========================================
+ Hits         3720     3824     +104     
- Misses       1999     2050      +51     
- Partials      505      626     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 5a63a1b into main Apr 19, 2024
11 checks passed
@lsrcz lsrcz deleted the refactor-terms branch April 19, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant