Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage the use of approximation with GrisetteSMTConfig #218

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Jun 30, 2024

Using approx for approximation isn't the preferred way, and we should almost always stick with precise and control the reasoning bit width with the types used during symbolic evaluation.

This pull request discouraged the use of approx, and we no longer require to use precise to indicate that we are doing precise reasoning. It is now the default.

Also, approx is renamed to approximate.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.31%. Comparing base (5f8dd25) to head (ecf02b9).

Files Patch % Lines
src/Grisette/Internal/Backend/Solving.hs 40.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   50.30%   50.31%           
=======================================
  Files         100      100           
  Lines        8452     8455    +3     
  Branches      707      706    -1     
=======================================
+ Hits         4252     4254    +2     
- Misses       3493     3495    +2     
+ Partials      707      706    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 9e80f67 into main Jun 30, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant