Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DivOr, FdivOr, LogBaseOr #231

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Introduce DivOr, FdivOr, LogBaseOr #231

merged 4 commits into from
Jul 15, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Jul 15, 2024

This pull request introduces DivOr, FdivOr, and LogBaseOr, and renames SafeDivision to SafeDiv, SafeFractional to SafeFdiv.

@lsrcz lsrcz self-assigned this Jul 15, 2024
@lsrcz lsrcz marked this pull request as ready for review July 15, 2024 11:35
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 63 lines in your changes missing coverage. Please review.

Project coverage is 52.97%. Comparing base (0c47419) to head (307464b).

Files Patch % Lines
src/Grisette/Internal/Core/Data/Class/SafeDiv.hs 64.91% 36 Missing and 4 partials ⚠️
.../Grisette/Unified/Internal/Class/UnifiedSafeDiv.hs 26.08% 17 Missing ⚠️
src/Grisette/Internal/SymPrim/SomeBV.hs 64.70% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   52.97%   52.97%           
=======================================
  Files         104      104           
  Lines        8546     8617   +71     
  Branches      768      775    +7     
=======================================
+ Hits         4527     4565   +38     
- Misses       3251     3277   +26     
- Partials      768      775    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit 28b345e into main Jul 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant