Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToSym for Union merges again #244

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Make ToSym for Union merges again #244

merged 3 commits into from
Aug 7, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Aug 7, 2024

This pull request adds the Mergeable superclass to ToSym. Also adds Mergeable constraint to liftToSym. This enables us to merge the resulting Union when we do toSym from Union to Union.

@lsrcz lsrcz added the bug Something isn't working label Aug 7, 2024
@lsrcz lsrcz self-assigned this Aug 7, 2024
@lsrcz lsrcz merged commit 93ad9c6 into main Aug 7, 2024
15 of 16 checks passed
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (d3e67e3) to head (b607c7d).
Report is 3 commits behind head on main.

Files Patch % Lines
src/Grisette/Internal/Core/Data/Class/ToSym.hs 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   54.50%   54.54%   +0.04%     
==========================================
  Files         117      117              
  Lines        9620     9625       +5     
  Branches      900      898       -2     
==========================================
+ Hits         5243     5250       +7     
  Misses       3477     3477              
+ Partials      900      898       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant