Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better symDistinct for SomeBV #247

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Add better symDistinct for SomeBV #247

merged 1 commit into from
Aug 11, 2024

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Aug 11, 2024

This pull request changes the behavior of symDistinct and requires it to have all-same bit-widths. Under the all-same bit-width assumption, the resulting formula would be a single distinct formula.

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@079a144). Learn more about missing BASE report.

Files Patch % Lines
src/Grisette/Internal/SymPrim/SomeBV.hs 0.00% 13 Missing ⚠️
src/Grisette/Internal/Core/Data/Class/SymEq.hs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage        ?   53.71%           
=======================================
  Files           ?      117           
  Lines           ?     9892           
  Branches        ?      941           
=======================================
  Hits            ?     5313           
  Misses          ?     3638           
  Partials        ?      941           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsrcz lsrcz merged commit dc83395 into main Aug 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant