Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lowering for uninterpreted functions #57

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Feb 21, 2023

This pull request allows the lowering for uninterpreted functions.

Lowering for concrete GeneralFun is still not allowed, but hopefully we will only lower symbolic Boolean values where concrete GeneralFun should all have been partial evaluated.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 32.23% // Head: 34.49% // Increases project coverage by +2.25% 🎉

Coverage data is based on head (4cb7cfb) compared to base (482c7a3).
Patch coverage: 59.37% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   32.23%   34.49%   +2.25%     
==========================================
  Files          48       48              
  Lines        4582     4598      +16     
  Branches      216      228      +12     
==========================================
+ Hits         1477     1586     +109     
+ Misses       2889     2784     -105     
- Partials      216      228      +12     
Impacted Files Coverage Δ
src/Grisette/Backend/SBV/Data/SMT/Lowering.hs 51.13% <58.06%> (+13.45%) ⬆️
...tte/IR/SymPrim/Data/Prim/PartialEval/GeneralFun.hs 100.00% <100.00%> (+100.00%) ⬆️
.../Grisette/IR/SymPrim/Data/Prim/PartialEval/Bool.hs 86.22% <0.00%> (-0.45%) ⬇️
src/Grisette/IR/SymPrim/Data/SymPrim.hs 20.84% <0.00%> (+0.97%) ⬆️
src/Grisette/IR/SymPrim/Data/Prim/Model.hs 46.90% <0.00%> (+1.03%) ⬆️
...c/Grisette/IR/SymPrim/Data/Prim/PartialEval/Num.hs 87.91% <0.00%> (+1.09%) ⬆️
...tte/IR/SymPrim/Data/Prim/InternedTerm/TermUtils.hs 38.16% <0.00%> (+1.14%) ⬆️
...IR/SymPrim/Data/Prim/InternedTerm/InternedCtors.hs 88.88% <0.00%> (+2.22%) ⬆️
...Grisette/IR/SymPrim/Data/Prim/InternedTerm/Term.hs 50.94% <0.00%> (+2.53%) ⬆️
src/Grisette/Core/Data/Class/Bool.hs 14.92% <0.00%> (+2.98%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lsrcz lsrcz merged commit 73157a1 into main Feb 27, 2023
@lsrcz lsrcz deleted the fix-lowering-ufuncs branch February 27, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant