DM-45346: Fix C++ library build path issues on MacOS #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
approved these changes
Jul 20, 2024
| @@ -7,6 +7,10 @@ | |||
|
|
|||
| #include "lsst/modelfit/parameters.h" | |||
|
|
|||
| #ifndef pow10 | |||
There was a problem hiding this comment.
What is supposed to define pow10 as macro?
Is there some missing header like math.h?
There was a problem hiding this comment.
OK. pow10 is removed in glibc 2.17 from math.h and is also a GNU extension
https://man7.org/linux/man-pages/man3/pow10.3.html
This still seems wrong to define it when the convenience macro is not defined.
Maybe just replace it with pow
pow10 is a deprecated GNU addition and unavailable on most platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.