DM-49427: Filter out old fanned-out messages in Keda #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-49427
branch
2 times, most recently
from
fd10743 to
fa335ff
Compare
The RedisStreamSession session takes care of making sure a connection is open, and closes on stream errors, and these two actions are completely decoupled from each other. This should be easier to understand and modify than the previous branch-based logic.
This change removes the last of the client micromanagement from the main Keda execution loop. Behavior is unchanged.
This change lets FannedOutVisit be used as a universal message representation in all other code. It also has the benefit that if the message is invalid, the stream is not closed. I considered moving the FAnnedOutVisit conversion into RedisStreamSession, but this way keeps the class "clean" with only Redis-specific elements.
This prevents the service from being overwhelmed in cases where the original fan-out message was delayed by server problems, as well as cases where processing can't keep up and develops a backlog.
This prevents the service from being overwhelmed without depending on the existing safeguards in the Fan-Out service or Knative itself.
kfindeisen
force-pushed
the
tickets/DM-49427
branch
from
60052aa to
0c840ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Redis connection management to something with lower algorithmic complexity, then adds a check to both Knative and Keda that rejects messages sent too long ago.