DM-51347: Add missing raise in process_visit. #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinleighh
force-pushed
the
tickets/DM-51347
branch
from
8b39819 to
b98eebd
Compare
kfindeisen
reviewed
Jun 17, 2025
python/activator/activator.py
Outdated
| _try_export(mwi, expid_set, _log) | ||
| exported = _try_export(mwi, expid_set, _log) | ||
| if not exported: | ||
| raise |
There was a problem hiding this comment.
Bare raise only works inside an exception handler, otherwise there's no "current exception" to reraise.
Why not simply call export_outputs directly?
kherner
reviewed
Jun 18, 2025
There was a problem hiding this comment.
Looks like @kfindeisen already covered it, but I join his comments.
erinleighh
force-pushed
the
tickets/DM-51347
branch
from
b98eebd to
cc59e33
Compare
erinleighh
force-pushed
the
tickets/DM-51347
branch
from
cc59e33 to
38642af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.