DM-51735: Stop caching spatial datasets in Prompt Processing #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinleighh
approved these changes
Jul 31, 2025
The offset is confusing and makes the code harder to maintain. It's also inefficient because it forces one visit's worth of datasets to get dropped even when the cache is being hit.
These datasets have little reuse value but take up several GB per image.
kfindeisen
force-pushed
the
tickets/DM-51735
branch
from
f428c9d to
a00cf81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the confusing "off by one" aspect of the local dataset cache, and doesn't cache (or check) spatial datasets at all.