Skip to content

Conversation

TallJimbo
Copy link
Member

No description provided.

@TallJimbo
Copy link
Member Author

@hsinfang & @kfindeisen , this is ready to merge at your convenience. It shouldn't need to be merged to avoid breakage (just deprecation warnings), and you definitely don't want to merge it until you're running against the upstream changes. Tests pass locally for me, and I assume the GHA failure is expected when the upstream changes aren't in the container you're using yet.

@kfindeisen
Copy link
Member

kfindeisen commented Jul 29, 2025

Given recent experience, we'll want to run integration tests first. Which version is supposed to be compatible? d_2025_07_30?

@TallJimbo
Copy link
Member Author

Yes, d_2025_07_30 should be the first with the upstream changes.

@hsinfang
Copy link
Collaborator

hsinfang commented Aug 6, 2025

Yesterday the default base was updated from d_2025_07_29 to d_2025_08_05. I'm going to rebase this ticket branch, run integration tests, and merge if tests go well.

@hsinfang
Copy link
Collaborator

hsinfang commented Aug 6, 2025

All good in testing. Merging next.

@hsinfang hsinfang merged commit f6a2bb0 into main Aug 6, 2025
11 checks passed
@hsinfang hsinfang deleted the tickets/DM-48980 branch August 6, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants