DM-52115: Catch networking errors for PP Sasquatch upload #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-52115
branch
from
2605ef7 to
4635982
Compare
tcjennings
approved these changes
Aug 13, 2025
SasquatchDispatcher throws two exceptions, SasquatchDispatchFailure and SasquatchDispatchPartialFailure, that are sibling classes and so must both be caught explicitly.
kfindeisen
force-pushed
the
tickets/DM-52115
branch
from
4635982 to
22bbcbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills in the exception handler for Sasquatch uploads to cover the case where some bundles were uploaded but others not.