Skip to content

add s3daemon::instance::env param #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

add s3daemon::instance::env param #8

merged 1 commit into from
Nov 13, 2024

Conversation

jhoblitt
Copy link
Member

No description provided.

@jhoblitt jhoblitt added the enhancement New feature or request label Nov 13, 2024
@jhoblitt jhoblitt force-pushed the IT-5635/env-vars branch 13 times, most recently from d2c1b30 to a017578 Compare November 13, 2024 19:39
@jhoblitt jhoblitt changed the title (WIP) add env var support add s3daemon::instance::env param Nov 13, 2024
cbarria
cbarria approved these changes Nov 13, 2024
View reviewed changes
Copy link

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍🏻

@jhoblitt jhoblitt merged commit f92ed91 into master Nov 13, 2024
13 checks passed
@jhoblitt jhoblitt deleted the IT-5635/env-vars branch November 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbarria cbarria cbarria approved these changes

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

@dtapiacl dtapiacl Awaiting requested review from dtapiacl

@badenerb badenerb Awaiting requested review from badenerb

@gseriche gseriche Awaiting requested review from gseriche

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhoblitt @cbarria