DM-39648: Add kafkit.settings module #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KafkitConnectionSettings makes it easy to gather configurations for a Kafka client based on environment variables (or environment variables that point to certificate files). The settings class also provides an ssl_context that's ready to use in setting up a consumer or producer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new module provides the
KafkaConnectionSettingsmodule we built in Squarebot. This class, built with Pydantic's BaseSettings provides a consistent framework for gathering Kafka client configurations from an app's environment variables. It also provides a ready-to-use SSLContext if TLS certs are included in the configuration.