DM-15075: Fix for editions that do not have a tracked_refs field #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an edition has a tracked_refs key of None, then the GitHub link is simply not shown. An edition can have tracked_refs = None because it uses an alternative tracking mode. Also switch to using the edition's `slug` field instead of the `git_refs` because the slug should always be present.
jonathansick
changed the title
tracked_refs field`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug when an LTD Keeper Edition had a
tracked_refsfield with a value ofNone(because the Edition does not use thegit_refstracking mode`).First, the GitHub link does not appear if
tracked_refsis not available.Second, version heuristics are now computed against the
slug.Fixes #6