Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40142: Infrastructure upgrades #52

Merged
merged 19 commits into from
Jul 24, 2023
Merged

DM-40142: Infrastructure upgrades #52

merged 19 commits into from
Jul 24, 2023

Conversation

jonathansick
Copy link
Member

@jonathansick jonathansick commented Jul 21, 2023 •
edited

Updates to the Times Square codebase to bring it up to our modern standards:

  • Adopt scriv for managing the changelog.
  • Adopt ruff for linting, and update the codebase accordingly.
  • Adopt the new neophile workflow for managing dependencies.
  • Adopt the new lsst-sqre/build-and-push-to-ghcr GitHub Action for building and pushing Docker images.
  • Adopt the new FastAPI lifespan function for handling start-up and shutdown.
  • Create a Sphinx documentation site at times-square.lsst.io.

@jonathansick
Adopt backtracking resolver
5dc6272
@jonathansick
Update depenencies
d23baf0
@jonathansick
Convert the changelog to Markdown
aaf5be7 
This enables us to migrate to scriv
@jonathansick
Adopt scriv for change logs
e77c127
@jonathansick
Update copyright
6dc5f1c
@jonathansick
Configure and apply Ruff to codebase
2a3cde2
@jonathansick
Adopt "examples" for Paths
84bada4 
FastAPI is deprecated "example", now using "examples".
@jonathansick
Use new SQLAlchemy 2 declarative_base
586e4fd
@jonathansick
Update GitHub Actions workflows
537808e 
- Use new actions in the main ci.yaml workflow
- Adopt the dependencies.yaml to update pre-commit hooks
- Use periodic-ci.yaml to test if the app is compatible with future
  dependencies.
- Delete unneeded tagging script
@jonathansick
Adopt new FastAPI lifespan
afb3804
@jonathansick
Update to Python 3.11.4
5682d85
@jonathansick
Drop running dependencies check in PR
b1c6358 
It's super annoying because it fails if the existing dependencies are
unhashed. This is definitely better as a weekly heads-up.
@jonathansick
Improve OpenAPI tagging
463d7fb 
- Create an enum of common tags to apply to path operations.
- Drop the v1 tag
@jonathansick
Drop hashes from dependencies
1952f1e
@jonathansick
Update changelog
896b469
@jonathansick jonathansick marked this pull request as ready for review July 24, 2023 18:53
@jonathansick jonathansick merged commit 0b9d5e6 into main Jul 24, 2023
4 checks passed
@jonathansick jonathansick deleted the tickets/DM-40142 branch July 24, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonathansick