Add table of metadata to listing pages

[mfisherlevine]

No description provided.

[SimonKrughoff]

I have a couple of relatively minor comments on the python side.

[czwa]

Minor comments. This is likely the limit of my javascript and css knowledge, so you may need to find other reviewers in the future if things get more complicated than this.

[ugyballoons]

Yes! That’s taught me not to attempt refactoring over breakfast. Am currently fixing this and adding a try block to the get request.

…

On 1 Jul 2022, at 10:56, Merlin Fisher-Levine ***@***.***> wrote: @mfisherlevine commented on this pull request. In src/rubintv/handlers/external/endpoints.py <#78 (comment)>: > ) return web.Response(text=page, content_type="text/html") +def get_metadata_json( + bucket_name: str, camera_slug: str, date_str: str +) -> str: + metadata_json = "{}" + metadata_url = get_metadata_url(bucket_name, camera_slug, date_str) + metadata_json = requests.get(metadata_url).text Sorry, comment from before went somewhere very strange. I think this is a mistake, right? You're accessing the result before the check for 200 return code. — Reply to this email directly, view it on GitHub <#78 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYMXULM3J252WWM7UYSQTVR26GRANCNFSM52CJQUPA>. You are receiving this because you are subscribed to this thread.