DM-35487: Tweak cardinal directions for All Sky camera #87
Conversation
| @@ -334,6 +349,10 @@ def month_names() -> List[str]: | |||
| return [date(2000, m, 1).strftime("%B") for m in list(range(1, 13))] | |||
|
|
|||
|
|
|||
| def get_static_resource_timestamp() -> int: | |||
| return int(os.path.getmtime("src/rubintv/static/stylesheets/main.css")) | |||
There was a problem hiding this comment.
This'll work, but I think there's a limitation here. I don't think git tracks filesystem metadata like modification date so this timestamp effectively gets set when the Docker image gets built (my expectation, at least). So this'll successfully burst caches, but won't let a browser used the cached style sheet or other asset files between rubintv builds — which isn't much of a performance loss.
The way I'd kind of expect to implement this is by doing some sort of hash calculation on the content during app start up and cache that in memory (like in the aiohttp app context or via functools.cache). But again, no real harm in what you've got.
There was a problem hiding this comment.
Yes, a hash generator that ran on startup across all the static files would be much better. I think that would take me a while to write though.
It's frustrating that aiohttp offers just this functionality but I can't find anything in the docs about how to use the corresponding url_for() function in the templates.
| @@ -334,6 +349,10 @@ def month_names() -> List[str]: | |||
| return [date(2000, m, 1).strftime("%B") for m in list(range(1, 13))] | |||
|
|
|||
|
|
|||
| def get_static_resource_timestamp() -> int: | |||
There was a problem hiding this comment.
Perhaps try functools.cache to reduce the filesystem hits? The result shouldn't change, so it's easy to use here.
There was a problem hiding this comment.
That's not something I've come across before. How does it work?
Is this a case of just adding a @cache decorator before the def? (After pulling functools in)
There was a problem hiding this comment.
Right. It's a function decorator, so it'll look like:
| def get_static_resource_timestamp() -> int: | |
| import functools | |
| @functools.cache | |
| def get_static_resource_timestamp() -> int: |
There was a problem hiding this comment.
That's great, thanks!
No description provided.