Skip to content

Conversation

RobertLuptonTheGood
Copy link
Member

No description provided.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if XY0 handling is correct here, but's definitely not the same as it was before. Other than that, looks good, of course, and sorry for the trouble.

if self._mask:
val = self._mask.get(col, row)
val = self._mask[col, row]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it matters in this context (or if the previous version was even correct), but to make this identical to what it was before, you want [col, row, afwImage.LOCAL].

@RobertLuptonTheGood RobertLuptonTheGood merged commit 6b65199 into master Jul 25, 2018
@ktlim ktlim deleted the tickets/DM-15197 branch August 25, 2018 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants