Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-15182: Add facility to change matplotlib colormap #8

Merged
merged 3 commits into from Jul 31, 2018

Conversation

jdswinbank
Copy link
Contributor

No description provided.

@jdswinbank
Copy link
Contributor Author

See also commentary on #5.

@kadrlica
Copy link
Contributor

Moving some comments/questions from #5...

@rhl this is my first attempt at implementing a facility to allow the user to set the image colormap (#1 and DM-15182. Some notes:

  • I've implemented both public (setImageColormap) and protected (_setImageColormap) methods with the idea that the public method would be eventually moved upstream to afwDisplay. (I'm not sure about the naming convention because the preceding function, show_colorbar, does not seem to conform with other methods in Display.)
  • I've inserted a stand-in for testing this facility in test_display_matplotlib.py. The test is currently commented out because I'm not sure whether we want to handle the creation of the display in setUp.

@jdswinbank
Copy link
Contributor Author

Review comment from @RobertLuptonTheGood:

I don't think I want to pass a pyplot.cm.XXX object to setImageColormap; so display.setImageColormap("gray"). If you agree (or can't convince me to the contrary) I'll make that change. It would be nice to come up with a subset of commonly supported names; at the very least "gray"

(Also some follow up Slack discussion, which I'm not recording here.)

@RobertLuptonTheGood — I think it'd be helpful if you can make further comments here, rather than Jira, just to save me from copying & pasting. Does that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants